From c16cb2e9dd09bb4bc153569bf0d8a107a055fe93 Mon Sep 17 00:00:00 2001 From: gnembon <41132274+gnembon@users.noreply.github.com> Date: Tue, 29 Nov 2022 21:14:44 +0100 Subject: [PATCH] find valid generation point should now test for biome --- src/main/java/carpet/helpers/FeatureGenerator.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/carpet/helpers/FeatureGenerator.java b/src/main/java/carpet/helpers/FeatureGenerator.java index 3eefd7ab..c6f00687 100644 --- a/src/main/java/carpet/helpers/FeatureGenerator.java +++ b/src/main/java/carpet/helpers/FeatureGenerator.java @@ -218,8 +218,8 @@ public class FeatureGenerator final HolderSet structureBiomes = structure.biomes(); if (!computeBox) { - Holder genBiome = generator.getBiomeSource().getNoiseBiome(QuartPos.fromBlock(pos.getX()), QuartPos.fromBlock(pos.getY()), QuartPos.fromBlock(pos.getZ()), seed.sampler()); - if (structureBiomes.contains(genBiome) && structure.findValidGenerationPoint(new Structure.GenerationContext( + //Holder genBiome = generator.getBiomeSource().getNoiseBiome(QuartPos.fromBlock(pos.getX()), QuartPos.fromBlock(pos.getY()), QuartPos.fromBlock(pos.getZ()), seed.sampler()); + if (structure.findValidGenerationPoint(new Structure.GenerationContext( world.registryAccess(), generator, generator.getBiomeSource(), seed, world.getStructureManager(), world.getSeed(), chunkPos, world, structureBiomes::contains )).isPresent())