From c08d857821787e05b282415713bce97ffa13da80 Mon Sep 17 00:00:00 2001 From: altrisi Date: Sat, 23 Jul 2022 23:56:13 +0200 Subject: [PATCH] Don't refresh local app store repo on world change Relates to #1508. --- src/main/java/carpet/script/utils/AppStoreManager.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/main/java/carpet/script/utils/AppStoreManager.java b/src/main/java/carpet/script/utils/AppStoreManager.java index bb714687..8f66a032 100644 --- a/src/main/java/carpet/script/utils/AppStoreManager.java +++ b/src/main/java/carpet/script/utils/AppStoreManager.java @@ -59,6 +59,11 @@ public class AppStoreManager { @Override public String validate(CommandSourceStack source, CarpetRule currentRule, String newValue, String stringInput) { + if (newValue.equals(currentRule.value())) { + // Don't refresh the local repo if it's the same (world change), helps preventing hitting rate limits from github when + // getting suggestions. Pending is a way to invalidate the cache when it gets old, and investigating api usage further + return newValue; + } APP_STORE_ROOT = StoreNode.folder(null, ""); if (newValue.equalsIgnoreCase("none")) {