From 848f06cb1c4f20b3a06e83559fe029dddd2d5be7 Mon Sep 17 00:00:00 2001 From: altrisi Date: Thu, 26 Mar 2026 01:59:50 +0100 Subject: [PATCH] Fix memory leak on fake player connection Fixes #2169 --- src/main/java/carpet/patches/FakeClientConnection.java | 9 +++++++++ .../java/carpet/patches/NetHandlerPlayServerFake.java | 6 ------ 2 files changed, 9 insertions(+), 6 deletions(-) diff --git a/src/main/java/carpet/patches/FakeClientConnection.java b/src/main/java/carpet/patches/FakeClientConnection.java index 8a1a1b56..8560257d 100644 --- a/src/main/java/carpet/patches/FakeClientConnection.java +++ b/src/main/java/carpet/patches/FakeClientConnection.java @@ -1,10 +1,14 @@ package carpet.patches; +import org.jspecify.annotations.Nullable; + import carpet.fakes.ClientConnectionInterface; +import io.netty.channel.ChannelFutureListener; import io.netty.channel.embedded.EmbeddedChannel; import net.minecraft.network.Connection; import net.minecraft.network.PacketListener; import net.minecraft.network.ProtocolInfo; +import net.minecraft.network.protocol.Packet; import net.minecraft.network.protocol.PacketFlow; public class FakeClientConnection extends Connection @@ -21,6 +25,11 @@ public class FakeClientConnection extends Connection public void setReadOnly() { } + + @Override + public void send(Packet packet, @Nullable ChannelFutureListener channelFutureListener, boolean bl) + { + } @Override public void handleDisconnection() diff --git a/src/main/java/carpet/patches/NetHandlerPlayServerFake.java b/src/main/java/carpet/patches/NetHandlerPlayServerFake.java index 143e7ad0..6bdd8c9a 100644 --- a/src/main/java/carpet/patches/NetHandlerPlayServerFake.java +++ b/src/main/java/carpet/patches/NetHandlerPlayServerFake.java @@ -3,7 +3,6 @@ package carpet.patches; import net.minecraft.network.Connection; import net.minecraft.network.chat.Component; import net.minecraft.network.chat.contents.TranslatableContents; -import net.minecraft.network.protocol.Packet; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.server.network.CommonListenerCookie; @@ -19,11 +18,6 @@ public class NetHandlerPlayServerFake extends ServerGamePacketListenerImpl super(minecraftServer, connection, serverPlayer, i); } - @Override - public void send(final Packet packetIn) - { - } - @Override public void disconnect(Component message) {