diff --git a/src/main/java/carpet/CarpetServer.java b/src/main/java/carpet/CarpetServer.java index 390e78f0..1e55bc6c 100644 --- a/src/main/java/carpet/CarpetServer.java +++ b/src/main/java/carpet/CarpetServer.java @@ -35,7 +35,7 @@ public class CarpetServer // static for now - easier to handle all around the co private static CommandDispatcher currentCommandDispatcher; public static CarpetScriptServer scriptServer; public static SettingsManager settingsManager; - public static List extensions = new ArrayList<>(); + public static final List extensions = new ArrayList<>(); // Separate from onServerLoaded, because a server can be loaded multiple times in singleplayer public static void manageExtension(CarpetExtension extension) diff --git a/src/main/java/carpet/CarpetSettings.java b/src/main/java/carpet/CarpetSettings.java index 4c31fe5f..c6cb9f4d 100644 --- a/src/main/java/carpet/CarpetSettings.java +++ b/src/main/java/carpet/CarpetSettings.java @@ -29,6 +29,7 @@ import static carpet.settings.RuleCategory.SURVIVAL; import static carpet.settings.RuleCategory.TNT; import static carpet.settings.RuleCategory.DISPENSER; +@SuppressWarnings("CanBeFinal") public class CarpetSettings { public static final String carpetVersion = "1.3.3+v200105"; diff --git a/src/main/java/carpet/fakes/MinecraftClientInferface.java b/src/main/java/carpet/fakes/MinecraftClientInferface.java index a96303ee..6e200c7f 100644 --- a/src/main/java/carpet/fakes/MinecraftClientInferface.java +++ b/src/main/java/carpet/fakes/MinecraftClientInferface.java @@ -2,5 +2,5 @@ package carpet.fakes; public interface MinecraftClientInferface { - public float getPausedTickDelta(); + float getPausedTickDelta(); } diff --git a/src/main/java/carpet/fakes/MobEntityInterface.java b/src/main/java/carpet/fakes/MobEntityInterface.java index ddab20fc..290e5304 100644 --- a/src/main/java/carpet/fakes/MobEntityInterface.java +++ b/src/main/java/carpet/fakes/MobEntityInterface.java @@ -7,7 +7,7 @@ import java.util.Map; public interface MobEntityInterface { - public GoalSelector getAI(boolean target); + GoalSelector getAI(boolean target); - public Map getTemporaryTasks(); + Map getTemporaryTasks(); } diff --git a/src/main/java/carpet/fakes/StructureFeatureInterface.java b/src/main/java/carpet/fakes/StructureFeatureInterface.java index f1180709..410f5055 100644 --- a/src/main/java/carpet/fakes/StructureFeatureInterface.java +++ b/src/main/java/carpet/fakes/StructureFeatureInterface.java @@ -7,6 +7,6 @@ import net.minecraft.world.gen.chunk.ChunkGeneratorConfig; public interface StructureFeatureInterface { - public boolean plopAnywhere(IWorld world, BlockPos pos); - public boolean plopAnywhere(IWorld world, BlockPos pos, ChunkGenerator generator); + boolean plopAnywhere(IWorld world, BlockPos pos); + boolean plopAnywhere(IWorld world, BlockPos pos, ChunkGenerator generator); } diff --git a/src/main/java/carpet/helpers/EntityPlayerActionPack.java b/src/main/java/carpet/helpers/EntityPlayerActionPack.java index 9222d0b3..346de1f4 100644 --- a/src/main/java/carpet/helpers/EntityPlayerActionPack.java +++ b/src/main/java/carpet/helpers/EntityPlayerActionPack.java @@ -25,9 +25,9 @@ import java.util.TreeMap; public class EntityPlayerActionPack { - private ServerPlayerEntity player; + private final ServerPlayerEntity player; - private Map actions = new TreeMap<>(); + private final Map actions = new TreeMap<>(); private BlockPos currentBlock; private int blockHitDelay; diff --git a/src/main/java/carpet/helpers/FeatureGenerator.java b/src/main/java/carpet/helpers/FeatureGenerator.java index 8f542373..87c76e52 100644 --- a/src/main/java/carpet/helpers/FeatureGenerator.java +++ b/src/main/java/carpet/helpers/FeatureGenerator.java @@ -95,7 +95,7 @@ public class FeatureGenerator return null; } - private static Map featureMap = new HashMap() {{ + private static final Map featureMap = new HashMap() {{ put("oak", simplePlop(Feature.NORMAL_TREE)); diff --git a/src/main/java/carpet/helpers/OptimizedExplosion.java b/src/main/java/carpet/helpers/OptimizedExplosion.java index 5e0184dd..66ae7a05 100644 --- a/src/main/java/carpet/helpers/OptimizedExplosion.java +++ b/src/main/java/carpet/helpers/OptimizedExplosion.java @@ -333,7 +333,7 @@ public class OptimizedExplosion private static void getAffectedPositionsOnPlaneX(Explosion e, int x, int yStart, int yEnd, int zStart, int zEnd) { - if (rayCalcDone == false) + if (!rayCalcDone) { final double xRel = (double) x / 15.0D * 2.0D - 1.0D; @@ -356,7 +356,7 @@ public class OptimizedExplosion private static void getAffectedPositionsOnPlaneY(Explosion e, int y, int xStart, int xEnd, int zStart, int zEnd) { - if (rayCalcDone == false) + if (!rayCalcDone) { final double yRel = (double) y / 15.0D * 2.0D - 1.0D; @@ -379,7 +379,7 @@ public class OptimizedExplosion private static void getAffectedPositionsOnPlaneZ(Explosion e, int z, int xStart, int xEnd, int yStart, int yEnd) { - if (rayCalcDone == false) + if (!rayCalcDone) { final double zRel = (double) z / 15.0D * 2.0D - 1.0D; diff --git a/src/main/java/carpet/helpers/PortalHelper.java b/src/main/java/carpet/helpers/PortalHelper.java index 2cba9115..baae0f66 100644 --- a/src/main/java/carpet/helpers/PortalHelper.java +++ b/src/main/java/carpet/helpers/PortalHelper.java @@ -8,12 +8,8 @@ public class PortalHelper { public static boolean player_holds_obsidian(PlayerEntity playerIn) { - if ( (!playerIn.getMainHandStack().isEmpty() - && playerIn.getMainHandStack().getItem() instanceof BlockItem && - ((BlockItem)(playerIn.getMainHandStack().getItem())).getBlock() == Blocks.OBSIDIAN )) - { - return true; - } - return false; + return (!playerIn.getMainHandStack().isEmpty() + && playerIn.getMainHandStack().getItem() instanceof BlockItem && + ((BlockItem) (playerIn.getMainHandStack().getItem())).getBlock() == Blocks.OBSIDIAN); } } diff --git a/src/main/java/carpet/helpers/RedstoneWireTurbo.java b/src/main/java/carpet/helpers/RedstoneWireTurbo.java index f44da166..b7bb9754 100644 --- a/src/main/java/carpet/helpers/RedstoneWireTurbo.java +++ b/src/main/java/carpet/helpers/RedstoneWireTurbo.java @@ -193,7 +193,7 @@ public class RedstoneWireTurbo private static final int West = 3; // Names for debug print statements - private static final char dirname[] = {'N', 'E', 'S', 'W'}; + private static final char[] dirname = {'N', 'E', 'S', 'W'}; /* * These lookup tables completely remap neighbor positions into a left-to-right @@ -269,7 +269,7 @@ public class RedstoneWireTurbo * neighbors that will receive updates. */ private static class UpdateNode { - public static enum Type { + public enum Type { UNKNOWN, REDSTONE, OTHER } diff --git a/src/main/java/carpet/mixins/DesertPyramidFeatureMixin.java b/src/main/java/carpet/mixins/DesertPyramidFeatureMixin.java index 1ea4ab23..98ea4d32 100644 --- a/src/main/java/carpet/mixins/DesertPyramidFeatureMixin.java +++ b/src/main/java/carpet/mixins/DesertPyramidFeatureMixin.java @@ -21,7 +21,7 @@ public abstract class DesertPyramidFeatureMixin extends AbstractTempleFeature, ? extends DefaultFeatureConfig> function_1) diff --git a/src/main/java/carpet/mixins/Entity_scarpetEventsMixin.java b/src/main/java/carpet/mixins/Entity_scarpetEventsMixin.java index c6306a9a..ca6a4576 100644 --- a/src/main/java/carpet/mixins/Entity_scarpetEventsMixin.java +++ b/src/main/java/carpet/mixins/Entity_scarpetEventsMixin.java @@ -14,7 +14,7 @@ public abstract class Entity_scarpetEventsMixin implements EntityInterface { @Shadow public boolean removed; - private EntityEventsGroup events = new EntityEventsGroup(); + private final EntityEventsGroup events = new EntityEventsGroup(); @Override public EntityEventsGroup getEventContainer() diff --git a/src/main/java/carpet/mixins/PistonBlock_movableTEMixin.java b/src/main/java/carpet/mixins/PistonBlock_movableTEMixin.java index 0b85b5ef..63e2bff0 100644 --- a/src/main/java/carpet/mixins/PistonBlock_movableTEMixin.java +++ b/src/main/java/carpet/mixins/PistonBlock_movableTEMixin.java @@ -77,14 +77,14 @@ public abstract class PistonBlock_movableTEMixin extends FacingBlock @Inject(method = "move", at = @At(value = "INVOKE", shift = At.Shift.BEFORE, target = "Ljava/util/List;size()I", ordinal = 4),locals = LocalCapture.CAPTURE_FAILHARD) private void onMove(World world_1, BlockPos blockPos_1, Direction direction_1, boolean boolean_1, - CallbackInfoReturnable cir, BlockPos blockPos_2, PistonHandler pistonHandler_1, - List list_1, List list_2, List list_3, int int_2, BlockState blockStates_1[], - Direction direction_2, Set set_1) + CallbackInfoReturnable cir, BlockPos blockPos_2, PistonHandler pistonHandler_1, + List list_1, List list_2, List list_3, int int_2, BlockState[] blockStates_1, + Direction direction_2, Set set_1) { //Get the blockEntities and remove them from the world before any magic starts to happen if (CarpetSettings.movableBlockEntities) { - list1_BlockEntities.set(Lists.newArrayList()); + list1_BlockEntities.set(Lists.newArrayList()); for (int i = 0; i < list_1.size(); ++i) { BlockPos blockpos = list_1.get(i); @@ -106,9 +106,9 @@ public abstract class PistonBlock_movableTEMixin extends FacingBlock "Lnet/minecraft/block/entity/BlockEntity;)V", ordinal = 0), locals = LocalCapture.CAPTURE_FAILHARD) private void setBlockEntityWithCarried(World world_1, BlockPos blockPos_1, Direction direction_1, boolean boolean_1, - CallbackInfoReturnable cir, BlockPos blockPos_2, PistonHandler pistonHandler_1, List list_1, - List list_2, List list_3, int int_2, BlockState blockStates_1[], Direction direction_2, Set set_1, - int int_3, BlockPos blockPos_4, BlockState blockState_1) + CallbackInfoReturnable cir, BlockPos blockPos_2, PistonHandler pistonHandler_1, List list_1, + List list_2, List list_3, int int_2, BlockState[] blockStates_1, Direction direction_2, Set set_1, + int int_3, BlockPos blockPos_4, BlockState blockState_1) { BlockEntity blockEntityPiston = PistonExtensionBlock.createBlockEntityPiston((BlockState) list_2.get(int_3), direction_1, boolean_1, false); diff --git a/src/main/java/carpet/mixins/PlayerManagerMixin.java b/src/main/java/carpet/mixins/PlayerManagerMixin.java index d6f9a64d..46864b4c 100644 --- a/src/main/java/carpet/mixins/PlayerManagerMixin.java +++ b/src/main/java/carpet/mixins/PlayerManagerMixin.java @@ -72,7 +72,7 @@ public abstract class PlayerManagerMixin serverPlayerEntity_3.kill(); continue; } - serverPlayerEntity_3.networkHandler.disconnect(new TranslatableText("multiplayer.disconnect.duplicate_login", new Object[0])); + serverPlayerEntity_3.networkHandler.disconnect(new TranslatableText("multiplayer.disconnect.duplicate_login")); } } diff --git a/src/main/java/carpet/mixins/RedstoneWireBlockMixin.java b/src/main/java/carpet/mixins/RedstoneWireBlockMixin.java index c2247f27..7fd650ea 100644 --- a/src/main/java/carpet/mixins/RedstoneWireBlockMixin.java +++ b/src/main/java/carpet/mixins/RedstoneWireBlockMixin.java @@ -36,10 +36,10 @@ public abstract class RedstoneWireBlockMixin implements RedstoneWireBlockInterfa private Set affectedNeighbors; @Shadow - private int increasePower(int int_1, BlockState blockState_1) { return 0; }; + private int increasePower(int int_1, BlockState blockState_1) { return 0; } @Shadow - private BlockState update(World world_1, BlockPos blockPos_1, BlockState blockState_1) { return null; }; + private BlockState update(World world_1, BlockPos blockPos_1, BlockState blockState_1) { return null; } // = diff --git a/src/main/java/carpet/mixins/ServerChunkManagerMixin.java b/src/main/java/carpet/mixins/ServerChunkManagerMixin.java index ab20320f..2ef3a2ec 100644 --- a/src/main/java/carpet/mixins/ServerChunkManagerMixin.java +++ b/src/main/java/carpet/mixins/ServerChunkManagerMixin.java @@ -75,6 +75,7 @@ public abstract class ServerChunkManagerMixin } } + @SuppressWarnings("UnresolvedMixinReference") @Redirect(method = "method_20801", at = @At( value = "INVOKE", target = "Lnet/minecraft/world/SpawnHelper;spawnEntitiesInChunk(Lnet/minecraft/entity/EntityCategory;Lnet/minecraft/world/World;Lnet/minecraft/world/chunk/WorldChunk;Lnet/minecraft/util/math/BlockPos;)V" @@ -88,6 +89,7 @@ public abstract class ServerChunkManagerMixin } } + @SuppressWarnings("UnresolvedMixinReference") @Redirect(method = "method_20801", at = @At( value = "INVOKE", target = "Lnet/minecraft/entity/EntityCategory;getSpawnCap()I" diff --git a/src/main/java/carpet/mixins/ServerPlayerInteractionManager_cactusMixin.java b/src/main/java/carpet/mixins/ServerPlayerInteractionManager_cactusMixin.java index 3a405cf2..5a99d629 100644 --- a/src/main/java/carpet/mixins/ServerPlayerInteractionManager_cactusMixin.java +++ b/src/main/java/carpet/mixins/ServerPlayerInteractionManager_cactusMixin.java @@ -21,7 +21,7 @@ public class ServerPlayerInteractionManager_cactusMixin )) private boolean activateWithOptionalCactus(BlockState blockState, World world_1, PlayerEntity playerEntity_1, Hand hand_1, BlockHitResult blockHitResult_1) { - Boolean flipped = BlockRotator.flipBlockWithCactus(blockState, world_1, playerEntity_1, hand_1, blockHitResult_1); + boolean flipped = BlockRotator.flipBlockWithCactus(blockState, world_1, playerEntity_1, hand_1, blockHitResult_1); if (flipped) return true; diff --git a/src/main/java/carpet/mixins/ServerWorld_fakePlayersMixin.java b/src/main/java/carpet/mixins/ServerWorld_fakePlayersMixin.java index 73b2bdab..1da9a056 100644 --- a/src/main/java/carpet/mixins/ServerWorld_fakePlayersMixin.java +++ b/src/main/java/carpet/mixins/ServerWorld_fakePlayersMixin.java @@ -14,7 +14,8 @@ import org.spongepowered.asm.mixin.injection.Redirect; @Mixin(ServerWorld.class) public abstract class ServerWorld_fakePlayersMixin { - @Shadow private boolean ticking; + @Shadow + boolean ticking; @Shadow /*@Nonnull*/ public abstract MinecraftServer getServer(); diff --git a/src/main/java/carpet/mixins/SummonCommandMixin.java b/src/main/java/carpet/mixins/SummonCommandMixin.java index 8056e1ee..13a0d835 100644 --- a/src/main/java/carpet/mixins/SummonCommandMixin.java +++ b/src/main/java/carpet/mixins/SummonCommandMixin.java @@ -45,7 +45,7 @@ public class SummonCommandMixin world.spawnEntity(skeletonHorseEntity_1); } world.addLightning(lightningEntity_1); - source.sendFeedback(new TranslatableText("commands.summon.success", new Object[]{lightningEntity_1.getDisplayName()}), true); + source.sendFeedback(new TranslatableText("commands.summon.success", lightningEntity_1.getDisplayName()), true); cir.setReturnValue(1); cir.cancel(); diff --git a/src/main/java/carpet/mixins/World_movableTEMixin.java b/src/main/java/carpet/mixins/World_movableTEMixin.java index 8fa1bbff..8e14b16d 100644 --- a/src/main/java/carpet/mixins/World_movableTEMixin.java +++ b/src/main/java/carpet/mixins/World_movableTEMixin.java @@ -34,7 +34,7 @@ public abstract class World_movableTEMixin implements WorldInterface private Profiler profiler; @Shadow - protected abstract WorldChunk getWorldChunk(BlockPos blockPos_1); + public abstract WorldChunk getWorldChunk(BlockPos blockPos_1); @Shadow public abstract BlockState getBlockState(BlockPos blockPos_1); diff --git a/src/main/java/carpet/patches/EntityPlayerMPFake.java b/src/main/java/carpet/patches/EntityPlayerMPFake.java index 1ad6cf0d..0b8bcdad 100644 --- a/src/main/java/carpet/patches/EntityPlayerMPFake.java +++ b/src/main/java/carpet/patches/EntityPlayerMPFake.java @@ -19,6 +19,7 @@ import net.minecraft.world.dimension.DimensionType; import carpet.fakes.ServerPlayerEntityInterface; import carpet.utils.Messenger; +@SuppressWarnings("EntityConstructor") public class EntityPlayerMPFake extends ServerPlayerEntity { public Runnable fixStartingPosition = () -> {}; @@ -93,6 +94,7 @@ public class EntityPlayerMPFake extends ServerPlayerEntity super(server, worldIn, profile, interactionManagerIn); } + @Override public void kill() { diff --git a/src/main/java/carpet/script/CarpetContext.java b/src/main/java/carpet/script/CarpetContext.java index bb1cdc80..5add0cd6 100644 --- a/src/main/java/carpet/script/CarpetContext.java +++ b/src/main/java/carpet/script/CarpetContext.java @@ -6,7 +6,7 @@ import net.minecraft.util.math.BlockPos; public class CarpetContext extends Context { public ServerCommandSource s; - public BlockPos origin; + public final BlockPos origin; public CarpetContext(ScriptHost host, ServerCommandSource source, BlockPos origin) { super(host); diff --git a/src/main/java/carpet/script/CarpetEventServer.java b/src/main/java/carpet/script/CarpetEventServer.java index dd8cae7b..20d0db87 100644 --- a/src/main/java/carpet/script/CarpetEventServer.java +++ b/src/main/java/carpet/script/CarpetEventServer.java @@ -43,12 +43,12 @@ import java.util.stream.Collectors; public class CarpetEventServer { - public List scheduledCalls = new LinkedList<>(); + public final List scheduledCalls = new LinkedList<>(); public static class Callback { - public String host; - public FunctionValue function; + public final String host; + public final FunctionValue function; public Callback(String host, FunctionValue function) { @@ -65,8 +65,8 @@ public class CarpetEventServer public static class ScheduledCall extends Callback { - public List args; - private CarpetContext ctx; + public final List args; + private final CarpetContext ctx; public long dueTime; public ScheduledCall(CarpetContext context, FunctionValue function, List args, long dueTime) @@ -103,8 +103,8 @@ public class CarpetEventServer public static class CallbackList { - public List callList; - public int reqArgs; + public final List callList; + public final int reqArgs; public CallbackList(int reqArgs) { @@ -454,7 +454,7 @@ public class CarpetEventServer { return stat.getType().getRegistry().getId(stat.getValue()); } - private Set skippedStats = new HashSet(){{ + private final Set skippedStats = new HashSet(){{ add(Stats.TIME_SINCE_DEATH); add(Stats.TIME_SINCE_REST); add(Stats.PLAY_ONE_MINUTE); @@ -476,14 +476,14 @@ public class CarpetEventServer // on projectile thrown (arrow from bows, crossbows, tridents, snoballs, e-pearls - public String name; - public static Map byName = new HashMap(){{ + public final String name; + public static final Map byName = new HashMap(){{ for (Event e: Event.values()) { put(e.name, e); } }}; - public CallbackList handler; + public final CallbackList handler; Event(String name, CallbackList eventHandler) { this.name = name; diff --git a/src/main/java/carpet/script/CarpetExpression.java b/src/main/java/carpet/script/CarpetExpression.java index cb10102a..6e6054ba 100644 --- a/src/main/java/carpet/script/CarpetExpression.java +++ b/src/main/java/carpet/script/CarpetExpression.java @@ -133,9 +133,9 @@ import static java.lang.Math.sqrt; public class CarpetExpression { - private ServerCommandSource source; - private BlockPos origin; - private Expression expr; + private final ServerCommandSource source; + private final BlockPos origin; + private final Expression expr; Expression getExpr() {return expr;} private static long tickStart = 0L; @@ -274,7 +274,7 @@ public class CarpetExpression return bs; } - private static Map particleCache = new HashMap<>(); + private static final Map particleCache = new HashMap<>(); private ParticleEffect getParticleData(String name) { ParticleEffect particle = particleCache.get(name); @@ -2145,7 +2145,7 @@ public class CarpetExpression args = Collections.singletonList(lv.get(3).evalValue(c)); else if (lv.size()>4) { - args = new ArrayList<>(lv.subList(3, lv.size()).stream().map((vv) -> vv.evalValue(c)).collect(Collectors.toList())); + args = lv.subList(3, lv.size()).stream().map((vv) -> vv.evalValue(c)).collect(Collectors.toList()); } ((EntityValue) v).setEvent((CarpetContext)c, what, function, args); @@ -2377,12 +2377,12 @@ public class CarpetExpression CarpetContext cc = (CarpetContext)c; return (c_, t_) -> new LazyListValue() { - int minx = cx-sminx; - int miny = cy-sminy; - int minz = cz-sminz; - int maxx = cx+smaxx; - int maxy = cy+smaxy; - int maxz = cz+smaxz; + final int minx = cx-sminx; + final int miny = cy-sminy; + final int minz = cz-sminz; + final int maxx = cx+smaxx; + final int maxy = cy+smaxy; + final int maxz = cz+smaxz; int x; int y; int z; @@ -3188,7 +3188,7 @@ public class CarpetExpression this.expr.addLazyFunction("schedule", -1, (c, t, lv) -> { if (lv.size()<2) throw new InternalExpressionException("'schedule' should have at least 2 arguments, delay and call name"); - Long delay = NumericValue.asNumber(lv.get(0).evalValue(c)).getLong(); + long delay = NumericValue.asNumber(lv.get(0).evalValue(c)).getLong(); Value functionValue = lv.get(1).evalValue(c); if (!(functionValue instanceof FunctionValue)) diff --git a/src/main/java/carpet/script/CarpetScriptHost.java b/src/main/java/carpet/script/CarpetScriptHost.java index 418681b3..012cba27 100644 --- a/src/main/java/carpet/script/CarpetScriptHost.java +++ b/src/main/java/carpet/script/CarpetScriptHost.java @@ -31,7 +31,7 @@ import static java.lang.Math.max; public class CarpetScriptHost extends ScriptHost { - private CarpetScriptServer scriptServer; + private final CarpetScriptServer scriptServer; private Tag globalState; private int saveTimeout; diff --git a/src/main/java/carpet/script/CarpetScriptServer.java b/src/main/java/carpet/script/CarpetScriptServer.java index 27b8f091..777d60de 100644 --- a/src/main/java/carpet/script/CarpetScriptServer.java +++ b/src/main/java/carpet/script/CarpetScriptServer.java @@ -33,14 +33,14 @@ import static net.minecraft.server.command.CommandManager.literal; public class CarpetScriptServer { //make static for now, but will change that later: - public CarpetScriptHost globalHost; - public Map modules; + public final CarpetScriptHost globalHost; + public final Map modules; public long tickStart; public boolean stopAll; - private Set holyMoly; - public CarpetEventServer events; + private final Set holyMoly; + public final CarpetEventServer events; - private static List bundledModuleData = new ArrayList(){{ + private static final List bundledModuleData = new ArrayList(){{ add(new BundledModule("camera")); add(new BundledModule("event_test")); add(new BundledModule("stats_test")); diff --git a/src/main/java/carpet/script/Context.java b/src/main/java/carpet/script/Context.java index 092a5697..31af496f 100644 --- a/src/main/java/carpet/script/Context.java +++ b/src/main/java/carpet/script/Context.java @@ -17,9 +17,9 @@ public class Context public static final int LOCALIZATION = 8; public static final int LVALUE = 9; - public Map variables = new HashMap<>(); + public final Map variables = new HashMap<>(); - public ScriptHost host; + public final ScriptHost host; Context(ScriptHost host) { diff --git a/src/main/java/carpet/script/EntityEventsGroup.java b/src/main/java/carpet/script/EntityEventsGroup.java index da753e48..6ea9d746 100644 --- a/src/main/java/carpet/script/EntityEventsGroup.java +++ b/src/main/java/carpet/script/EntityEventsGroup.java @@ -21,7 +21,7 @@ import java.util.stream.Collectors; public class EntityEventsGroup { - private Map> actions; + private final Map> actions; public EntityEventsGroup() { actions = new EnumMap<>(EntityEventType.class); @@ -96,10 +96,10 @@ public class EntityEventsGroup } }; - public static Map byName = Arrays.stream(EntityEventType.values()).collect(Collectors.toMap(ev -> ev.id, ev -> ev)); + public static final Map byName = Arrays.stream(EntityEventType.values()).collect(Collectors.toMap(ev -> ev.id, ev -> ev)); - public int argcount; - public String id; + public final int argcount; + public final String id; EntityEventType(String identifier, int args) { id = identifier; @@ -121,6 +121,6 @@ public class EntityEventsGroup protected List makeArgs(Entity entity, Object ... args) { return Collections.singletonList(new EntityValue(entity)); - }; + } } } diff --git a/src/main/java/carpet/script/Expression.java b/src/main/java/carpet/script/Expression.java index 342834c8..ebd1d49c 100644 --- a/src/main/java/carpet/script/Expression.java +++ b/src/main/java/carpet/script/Expression.java @@ -357,7 +357,7 @@ public class Expression implements Cloneable "2.71828182845904523536028747135266249775724709369995957496696762772407663"); // %[argument_index$][flags][width][.precision][t]conversion - private static Pattern formatPattern = Pattern.compile("%(\\d+\\$)?([-#+ 0,(\\<]*)?(\\d+)?(\\.\\d+)?([tT])?([a-zA-Z%])"); + private static final Pattern formatPattern = Pattern.compile("%(\\d+\\$)?([-#+ 0,(<]*)?(\\d+)?(\\.\\d+)?([tT])?([a-zA-Z%])"); /** The current infix expression */ private String expression; @@ -387,10 +387,10 @@ public class Expression implements Cloneable private LazyValue ast = null; /** script specific operatos and built-in functions */ - private Map operators = new Object2ObjectOpenHashMap<>(); + private final Map operators = new Object2ObjectOpenHashMap<>(); boolean isAnOperator(String opname) { return operators.containsKey(opname) || operators.containsKey(opname+"u");} - private Map functions = new Object2ObjectOpenHashMap<>(); + private final Map functions = new Object2ObjectOpenHashMap<>(); Set getFunctionNames() {return functions.keySet();} @Override @@ -2878,7 +2878,6 @@ public class Expression implements Cloneable else if (fmt == '%') { //skip /%% - ; } else { @@ -3128,7 +3127,7 @@ public class Expression implements Cloneable } - static Expression none = new Expression("null"); + static final Expression none = new Expression("null"); /** * @param expression . */ diff --git a/src/main/java/carpet/script/ExpressionInspector.java b/src/main/java/carpet/script/ExpressionInspector.java index 3eddc45c..e4eaa892 100644 --- a/src/main/java/carpet/script/ExpressionInspector.java +++ b/src/main/java/carpet/script/ExpressionInspector.java @@ -46,7 +46,7 @@ public class ExpressionInspector { Set allFunctions = (new CarpetExpression("null", null, null)).getExpr().getFunctionNames(); scarpetFunctions = new TreeSet<>(new Expression("null").getFunctionNames()); - APIFunctions = new TreeSet<>(allFunctions.stream().filter(s -> !scarpetFunctions.contains(s)).collect(Collectors.toSet())); + APIFunctions = allFunctions.stream().filter(s -> !scarpetFunctions.contains(s)).collect(Collectors.toCollection(TreeSet::new)); } public static List suggestFunctions(ScriptHost host, String previous, String prefix) diff --git a/src/main/java/carpet/script/exception/CarpetExpressionException.java b/src/main/java/carpet/script/exception/CarpetExpressionException.java index 2c84bfa4..f19fcd80 100644 --- a/src/main/java/carpet/script/exception/CarpetExpressionException.java +++ b/src/main/java/carpet/script/exception/CarpetExpressionException.java @@ -8,7 +8,7 @@ import java.util.List; public class CarpetExpressionException extends RuntimeException { - public List stack; + public final List stack; public CarpetExpressionException(String message, List stack) { diff --git a/src/main/java/carpet/script/exception/ExitStatement.java b/src/main/java/carpet/script/exception/ExitStatement.java index 9b772923..0504e896 100644 --- a/src/main/java/carpet/script/exception/ExitStatement.java +++ b/src/main/java/carpet/script/exception/ExitStatement.java @@ -5,7 +5,7 @@ import carpet.script.value.Value; /* Exception thrown to terminate execution mid expression (aka return statement) */ public class ExitStatement extends RuntimeException { - public Value retval; + public final Value retval; public ExitStatement(Value value) { retval = value; diff --git a/src/main/java/carpet/script/exception/ExpressionException.java b/src/main/java/carpet/script/exception/ExpressionException.java index fc475481..3d07f8ee 100644 --- a/src/main/java/carpet/script/exception/ExpressionException.java +++ b/src/main/java/carpet/script/exception/ExpressionException.java @@ -15,8 +15,8 @@ import static carpet.script.ExpressionInspector.Expression_getName; /* The expression evaluators exception class. */ public class ExpressionException extends RuntimeException { - public Context context; - public List stack = new ArrayList<>(); + public final Context context; + public final List stack = new ArrayList<>(); public ExpressionException(Context c, String message) { super(makeMessage(c, null, null, message)); @@ -35,7 +35,7 @@ public class ExpressionException extends RuntimeException context = c; } - private static Fluff.TriFunction> errorMaker = (expr, token, errmessage) -> + private static final Fluff.TriFunction> errorMaker = (expr, token, errmessage) -> { List errMsg = new ArrayList<>(); diff --git a/src/main/java/carpet/script/value/BlockValue.java b/src/main/java/carpet/script/value/BlockValue.java index da9704d0..d8d199ed 100644 --- a/src/main/java/carpet/script/value/BlockValue.java +++ b/src/main/java/carpet/script/value/BlockValue.java @@ -36,8 +36,8 @@ public class BlockValue extends Value public static final BlockValue AIR = new BlockValue(Blocks.AIR.getDefaultState(), null, BlockPos.ORIGIN); public static final BlockValue NULL = new BlockValue(null, null, null); private BlockState blockState; - private BlockPos pos; - private ServerWorld world; + private final BlockPos pos; + private final ServerWorld world; private CompoundTag data; public static BlockValue fromCoords(CarpetContext c, int x, int y, int z) @@ -46,7 +46,7 @@ public class BlockValue extends Value return new BlockValue(null, c.s.getWorld(), pos); } - private static Map bvCache= new HashMap<>(); + private static final Map bvCache= new HashMap<>(); public static BlockValue fromString(String str) { try @@ -294,8 +294,8 @@ public class BlockValue extends Value public static class LocatorResult { - public BlockValue block; - public int offset; + public final BlockValue block; + public final int offset; LocatorResult(BlockValue b, int o) { block = b; @@ -306,9 +306,9 @@ public class BlockValue extends Value public static class VectorLocator { public Vec3d vec; - public int offset; - public double yaw; - public double pitch; + public final int offset; + public final double yaw; + public final double pitch; public boolean fromBlock; VectorLocator(Vec3d v, int o) { @@ -358,9 +358,9 @@ public class BlockValue extends Value EASTUP("east-up", 0.0, 0.6, 0.5, Direction.EAST), WESTUP("west-up", 1.0, 0.6, 0.5, Direction.WEST); - public String name; - public Vec3d hitOffset; - public Direction facing; + public final String name; + public final Vec3d hitOffset; + public final Direction facing; private static final Map DIRECTION_MAP = Arrays.stream(values()).collect(Collectors.toMap(SpecificDirection::getName, d -> d)); diff --git a/src/main/java/carpet/script/value/EntityValue.java b/src/main/java/carpet/script/value/EntityValue.java index 0489a28b..e88c4900 100644 --- a/src/main/java/carpet/script/value/EntityValue.java +++ b/src/main/java/carpet/script/value/EntityValue.java @@ -62,14 +62,14 @@ import static carpet.script.value.NBTSerializableValue.nameFromRegistryId; // TODO: decide whether copy(entity) should duplicate entity in the world. public class EntityValue extends Value { - private Entity entity; + private final Entity entity; public EntityValue(Entity e) { entity = e; } - private static Map selectorCache = new HashMap<>(); + private static final Map selectorCache = new HashMap<>(); public static Collection getEntitiesFromSelector(ServerCommandSource source, String selector) { try @@ -177,7 +177,7 @@ public class EntityValue extends Value return res; //TODO add more here like search by tags, or type //if (who.startsWith('tag:')) } - private static Map, Predicate>> entityPredicates = + private static final Map, Predicate>> entityPredicates = new HashMap, Predicate>>() {{ put("*", Pair.of(null, EntityPredicates.VALID_ENTITY)); @@ -192,7 +192,7 @@ public class EntityValue extends Value throw new InternalExpressionException("Unknown entity feature: "+what); return featureAccessors.get(what).apply(entity, arg); } - private static Map inventorySlots = new HashMap(){{ + private static final Map inventorySlots = new HashMap(){{ put("mainhand", EquipmentSlot.MAINHAND); put("offhand", EquipmentSlot.OFFHAND); put("head", EquipmentSlot.HEAD); @@ -200,7 +200,7 @@ public class EntityValue extends Value put("legs", EquipmentSlot.LEGS); put("feet", EquipmentSlot.FEET); }}; - private static Map> featureAccessors = new HashMap>() {{ + private static final Map> featureAccessors = new HashMap>() {{ //put("test", (e, a) -> a == null ? Value.NULL : new StringValue(a.getString())); put("removed", (entity, arg) -> new NumericValue(entity.removed)); put("uuid",(e, a) -> new StringValue(e.getUuidAsString())); @@ -440,20 +440,6 @@ public class EntityValue extends Value }); }}; - private static Req assertEntityArgType(Class klass, Value arg) - { - if (!(arg instanceof EntityValue)) - { - return null; - } - Entity e = ((EntityValue) arg).getEntity(); - if (!(klass.isAssignableFrom(e.getClass()))) - { - return null; - } - return (Req)e; - } - public void set(String what, Value toWhat) { if (!(featureModifiers.containsKey(what))) @@ -515,7 +501,7 @@ public class EntityValue extends Value - private static Map> featureModifiers = new HashMap>() {{ + private static final Map> featureModifiers = new HashMap>() {{ put("remove", (entity, value) -> entity.remove()); put("health", (e, v) -> { if (e instanceof LivingEntity) ((LivingEntity) e).setHealth((float) NumericValue.asNumber(v).getDouble()); }); put("kill", (e, v) -> e.kill()); diff --git a/src/main/java/carpet/script/value/Value.java b/src/main/java/carpet/script/value/Value.java index 3755ca8a..f97fb8d5 100644 --- a/src/main/java/carpet/script/value/Value.java +++ b/src/main/java/carpet/script/value/Value.java @@ -39,7 +39,7 @@ public abstract class Value implements Comparable, Cloneable } public Value reboundedTo(String var) { - Value copy = null; + Value copy; try { copy = (Value)clone(); @@ -202,5 +202,5 @@ public abstract class Value implements Comparable, Cloneable // should never happen throw new InternalExpressionException("Cannot make a copy of value: "+this); } - }; + } } diff --git a/src/main/java/carpet/settings/SettingsManager.java b/src/main/java/carpet/settings/SettingsManager.java index 59977691..b67ae08f 100644 --- a/src/main/java/carpet/settings/SettingsManager.java +++ b/src/main/java/carpet/settings/SettingsManager.java @@ -242,7 +242,7 @@ public class SettingsManager Map result = new HashMap(); while ((line = reader.readLine()) != null) { - line = line.replaceAll("\\r|\\n", ""); + line = line.replaceAll("[\\r\\n]", ""); if ("locked".equalsIgnoreCase(line)) { confLocked = true; @@ -286,9 +286,7 @@ public class SettingsManager { if (rule.name.toLowerCase(Locale.ROOT).contains(lcSearch)) return true; // substring match, case insensitive for (String c : rule.categories) if (c.equals(search)) return true; // category exactly, case sensitive - if (Sets.newHashSet(rule.description.toLowerCase(Locale.ROOT).split("\\W+")).contains(lcSearch)) - return true; // contains full term in description, but case insensitive - return false; + return Sets.newHashSet(rule.description.toLowerCase(Locale.ROOT).split("\\W+")).contains(lcSearch); // contains full term in description, but case insensitive }).sorted().collect(ImmutableList.toImmutableList()); } diff --git a/src/main/java/carpet/utils/BlockInfo.java b/src/main/java/carpet/utils/BlockInfo.java index eb7fe510..548033eb 100644 --- a/src/main/java/carpet/utils/BlockInfo.java +++ b/src/main/java/carpet/utils/BlockInfo.java @@ -25,7 +25,7 @@ import java.util.Map; public class BlockInfo { - public static Map soundName = new HashMap() {{ + public static final Map soundName = new HashMap() {{ put(BlockSoundGroup.WOOD, "wood" ); put(BlockSoundGroup.GRAVEL, "gravel"); put(BlockSoundGroup.GRASS, "grass" ); @@ -50,7 +50,7 @@ public class BlockInfo put(BlockSoundGroup.LANTERN , "lantern" ); }}; - public static Map mapColourName = new HashMap() {{ + public static final Map mapColourName = new HashMap() {{ put(MaterialColor.AIR , "air" ); put(MaterialColor.GRASS , "grass" ); put(MaterialColor.SAND , "sand" ); @@ -105,7 +105,7 @@ public class BlockInfo put(MaterialColor.BLACK_TERRACOTTA , "black_terracotta" ); }}; - public static Map materialName = new HashMap() {{ + public static final Map materialName = new HashMap() {{ put(Material.AIR , "air" ); put(Material.STRUCTURE_VOID , "void" ); put(Material.PORTAL , "portal" ); @@ -233,7 +233,7 @@ public class BlockInfo long total_time = (total_ticks)/1000/20; return Messenger.s(String.format(" - Wander chance above: %.1f%%\n - Average standby above: %s", (100.0F*success)/1000, - ((total_time>5000)?"INFINITY":(Long.toString(total_time)+" s")) + ((total_time>5000)?"INFINITY":(total_time +" s")) )); } } diff --git a/src/main/java/carpet/utils/CarpetProfiler.java b/src/main/java/carpet/utils/CarpetProfiler.java index 984fbbe9..57ec9ea1 100644 --- a/src/main/java/carpet/utils/CarpetProfiler.java +++ b/src/main/java/carpet/utils/CarpetProfiler.java @@ -21,9 +21,9 @@ public class CarpetProfiler private static int tick_health_elapsed = 0; private static TYPE test_type = TYPE.NONE; //1 for ticks, 2 for entities; private static long current_tick_start = 0; - private static String[] GENERAL_SECTIONS = {"Network", "Autosave", "Async Tasks"}; - private static String[] DIMENSIONS = {"overworld", "the_end", "the_nether"}; - private static String[] SECTIONS = { + private static final String[] GENERAL_SECTIONS = {"Network", "Autosave", "Async Tasks"}; + private static final String[] DIMENSIONS = {"overworld", "the_end", "the_nether"}; + private static final String[] SECTIONS = { "Spawning and Random Ticks", "Ticket Manager","Unloading", "Blocks", "Entities", "Block Entities", "Entities (Client)", "Block Entities (Client)", @@ -39,10 +39,10 @@ public class CarpetProfiler public static class ProfilerToken { - public TYPE type; - public Object section; - public long start; - public World world; + public final TYPE type; + public final Object section; + public final long start; + public final World world; public ProfilerToken(TYPE type, Object section, World world, long start) { diff --git a/src/main/java/carpet/utils/Messenger.java b/src/main/java/carpet/utils/Messenger.java index 78be6bef..3b422262 100644 --- a/src/main/java/carpet/utils/Messenger.java +++ b/src/main/java/carpet/utils/Messenger.java @@ -114,7 +114,7 @@ public class Messenger { message = "w"+message; } - String parts[] = message.split("\\s", 2); + String[] parts = message.split("\\s", 2); String desc = parts[0]; String str = ""; if (parts.length > 1) str = parts[1]; diff --git a/src/main/java/carpet/utils/SpawnReporter.java b/src/main/java/carpet/utils/SpawnReporter.java index b84fdbc7..d1dbcfa1 100644 --- a/src/main/java/carpet/utils/SpawnReporter.java +++ b/src/main/java/carpet/utils/SpawnReporter.java @@ -323,7 +323,7 @@ public class SpawnReporter "w ' to enable")); return report; } - Long duration = (long) worldIn.getServer().getTicks() - track_spawns; + long duration = (long) worldIn.getServer().getTicks() - track_spawns; report.add(Messenger.c("bw --------------------")); String simulated = mock_spawns?"[SIMULATED] ":""; String location = (lower_spawning_limit != null)?String.format("[in (%d, %d, %d)x(%d, %d, %d)]", @@ -410,8 +410,8 @@ public class SpawnReporter continue; // vanilla bug boolean canspawn = SpawnHelper.canSpawn(SpawnRestriction.getLocation(spawnEntry.type), worldIn, pos, spawnEntry.type); int will_spawn = -1; - boolean fits = false; - boolean fits1 = false; + boolean fits; + boolean fits1; MobEntity mob; try