From 531d1356a6a5027df69fde4bfae258f7f40d61d4 Mon Sep 17 00:00:00 2001 From: gnembon Date: Thu, 16 Apr 2020 21:11:12 -0300 Subject: [PATCH] merge fixes --- .../carpet/script/utils/CarpetArgParser.java | 3 +- .../java/carpet/script/value/BlockValue.java | 52 ------------------- 2 files changed, 2 insertions(+), 53 deletions(-) diff --git a/src/main/java/carpet/script/utils/CarpetArgParser.java b/src/main/java/carpet/script/utils/CarpetArgParser.java index eeafe256..9f24546d 100644 --- a/src/main/java/carpet/script/utils/CarpetArgParser.java +++ b/src/main/java/carpet/script/utils/CarpetArgParser.java @@ -23,7 +23,8 @@ public class CarpetArgParser Value v1 = params.get(0 + offset).evalValue(c); if (v1 instanceof BlockValue) { - return (new Vector3Argument(new Vec3d(((BlockValue) v1).getPos()).add(0.5,0.5,0.5), 1+offset)).fromBlock(); + // pos + 0.5v + return (new Vector3Argument(Vec3d.method_24953(((BlockValue) v1).getPos()), 1+offset)).fromBlock(); } if (v1 instanceof ListValue) { diff --git a/src/main/java/carpet/script/value/BlockValue.java b/src/main/java/carpet/script/value/BlockValue.java index 4de012be..f117578f 100644 --- a/src/main/java/carpet/script/value/BlockValue.java +++ b/src/main/java/carpet/script/value/BlockValue.java @@ -72,58 +72,6 @@ public class BlockValue extends Value throw new InternalExpressionException("Cannot parse block: "+str); } - public static VectorLocator locateVec(CarpetContext c, List params, int offset) - { - return locateVec(c,params, offset, false); - } - public static VectorLocator locateVec(CarpetContext c, List params, int offset, boolean optionalDirection) - { - try - { - Value v1 = params.get(0 + offset).evalValue(c); - if (v1 instanceof BlockValue) - { - // pos + 0.5v - return (new VectorLocator(Vec3d.method_24953(((BlockValue) v1).getPos()), 1+offset)).fromBlock(); - } - if (v1 instanceof ListValue) - { - List args = ((ListValue) v1).getItems(); - Vec3d pos = new Vec3d( - NumericValue.asNumber(args.get(0)).getDouble(), - NumericValue.asNumber(args.get(1)).getDouble(), - NumericValue.asNumber(args.get(2)).getDouble()); - double yaw = 0.0D; - double pitch = 0.0D; - if (args.size()>3 && optionalDirection) - { - yaw = NumericValue.asNumber(args.get(3)).getDouble(); - pitch = NumericValue.asNumber(args.get(4)).getDouble(); - } - return new VectorLocator(pos,offset+1, yaw, pitch); - } - Vec3d pos = new Vec3d( - NumericValue.asNumber(v1).getDouble(), - NumericValue.asNumber(params.get(1 + offset).evalValue(c)).getDouble(), - NumericValue.asNumber(params.get(2 + offset).evalValue(c)).getDouble()); - double yaw = 0.0D; - double pitch = 0.0D; - int eatenLength = 3; - if (params.size()>3+offset && optionalDirection) - { - yaw = NumericValue.asNumber(params.get(3 + offset).evalValue(c)).getDouble(); - pitch = NumericValue.asNumber(params.get(4 + offset).evalValue(c)).getDouble(); - eatenLength = 5; - } - - return new VectorLocator(pos,offset+eatenLength, yaw, pitch); - } - catch (IndexOutOfBoundsException e) - { - throw new InternalExpressionException("Position should be defined either by three coordinates, or a block value"); - } - } - public static BlockPos locateBlockPos(CarpetContext c, int xpos, int ypos, int zpos) { return new BlockPos(c.origin.getX() + xpos, c.origin.getY() + ypos, c.origin.getZ() + zpos);