From 177179b70ab222a51eaebba705c67e86171ae8a6 Mon Sep 17 00:00:00 2001 From: altrisi Date: Mon, 26 Jun 2023 18:33:20 +0200 Subject: [PATCH] Don't use `getPlayerOrException` in `CarpetScriptHost` --- src/main/java/carpet/script/CarpetScriptHost.java | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/src/main/java/carpet/script/CarpetScriptHost.java b/src/main/java/carpet/script/CarpetScriptHost.java index 6cee11d7..9c775c60 100644 --- a/src/main/java/carpet/script/CarpetScriptHost.java +++ b/src/main/java/carpet/script/CarpetScriptHost.java @@ -675,12 +675,8 @@ public class CarpetScriptHost extends ScriptHost return this; } // user based - ServerPlayer player; - try - { - player = source.getPlayerOrException(); - } - catch (CommandSyntaxException ignored) + ServerPlayer player = source.getPlayer(); + if (player == null) { throw new SimpleCommandExceptionType(Component.literal("Cannot run player based apps without the player context")).create(); } @@ -1057,11 +1053,7 @@ public class CarpetScriptHost extends ScriptHost responsibleSource = source; errorSnooper = (expr, /*Nullable*/ token, ctx, message) -> { - try - { - source.getPlayerOrException(); - } - catch (CommandSyntaxException e) + if (!source.isPlayer()) { return null; }